Fix mobile overlay not closing on navigation link clicks#1198
Merged
jderochervlk merged 2 commits intovlk/refactor-navigationfrom Feb 21, 2026
Merged
Fix mobile overlay not closing on navigation link clicks#1198jderochervlk merged 2 commits intovlk/refactor-navigationfrom
jderochervlk merged 2 commits intovlk/refactor-navigationfrom
Conversation
Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update navbar based on review feedback from PR #1195
Fix mobile overlay not closing on navigation link clicks
Feb 18, 2026
jderochervlk
approved these changes
Feb 18, 2026
jderochervlk
added a commit
that referenced
this pull request
Feb 28, 2026
* refactor: refactoring navbars * making progress on the nav * scrolling works again * refactoring * mobile overlay works * tests are passing * done with mobile overlay * screenshots * removing top padding * fix playground * remove unused open * fix issue with homepage reloading nonstop * restor mdx route * remove dummy page * fixing docs * fix syntax lookup * remove build errors and warnings * commit screenshot changes * chore: update vitest screenshots [skip ci] * remove unused values * remove unused file * tidying up * fix version dropdown * Update src/components/Search.res Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/components/BreadCrumbs.res Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix mobile overlay not closing on navigation link clicks (#1198) * Initial plan * Add onClick handlers to close mobile overlay for all navigation links Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jderochervlk <60623931+jderochervlk@users.noreply.github.com> * PR feedback. * PR feedback * cleanup * Fix sidebar scrolling when it shouldn't --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile overlay remained open after clicking navigation links because only the Playground link had an onClick handler. Navigation without closing the overlay creates poor UX.
Changes:
onClick=toggleMobileOverlayto in-app links (Blog, Community, Packages)onClick=closeMobileOverlayto external links (X, Bluesky, GitHub, Forum)External links use
closeMobileOverlayinstead oftoggleMobileOverlaysince they navigate away from the app.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.